Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tail-sampling processor: drop spans matching an attribute #2972

Closed
LukeMathWalker opened this issue Apr 1, 2021 · 3 comments
Closed

Tail-sampling processor: drop spans matching an attribute #2972

LukeMathWalker opened this issue Apr 1, 2021 · 3 comments
Labels
processor/tailsampling Tail sampling processor question Further information is requested

Comments

@LukeMathWalker
Copy link

It is currently possible to prescribe that spans matching a certain condition are always sampled.
As far as I can see, there is no mechanism to do the opposite (even in other processors): how do I instruct the collector to always drop spans matching a certain condition?

E.g. drop all spans where the HTTP path is /health_check.

Looking at the source, it would be fairly simple to add this functionality to the tail-sampling processor and I'd be happy to open a PR for it, but I am also aware of #1797 - what is the best way forward here?

@alolita alolita added the processor/tailsampling Tail sampling processor label Sep 30, 2021
@HuBaX
Copy link

HuBaX commented Oct 4, 2021

Is anyone working on this? I'm asking because I'd like to implement this.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 7, 2022
@jpkrohling jpkrohling added question Further information is requested and removed Stale labels Nov 30, 2022
@jpkrohling
Copy link
Member

The string attribute now has an invert_match attribute that allows you to achieve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/tailsampling Tail sampling processor question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants