Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[extension/db_storage] Batch implementation is not transactional #29730

Closed
dmitryax opened this issue Dec 11, 2023 · 4 comments
Closed

[extension/db_storage] Batch implementation is not transactional #29730

dmitryax opened this issue Dec 11, 2023 · 4 comments
Assignees
@andrefrco
Labels
bug Something isn't working closed as inactive extension/storage/dbstorage good first issue Good for newcomers help wanted Extra attention is needed Stale

Comments

@dmitryax
Copy link
Member

dmitryax commented Dec 11, 2023 •
edited
Loading

What happened?

client.Batch method implementation should be wrapped in a transaction. If any of the batch operations fails, the database state must not be changed.

Collector version

0.90.1
@dmitryax dmitryax added bug Something isn't working extension/storage/dbstorage needs triage New item requiring triage help wanted Extra attention is needed good first issue Good for newcomers and removed needs triage New item requiring triage labels Dec 11, 2023
@github-actions github-actions bot mentioned this issue Dec 12, 2023
Closed
95 tasks
@andrefrco
Copy link

I can work on it

@dmitryax
Copy link
Member Author

dmitryax commented Jan 9, 2024

Thank you, @andrefrco!

@andrefrco andrefrco mentioned this issue Jan 14, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Mar 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrefrco andrefrco

Labels
bug Something isn't working closed as inactive extension/storage/dbstorage good first issue Good for newcomers help wanted Extra attention is needed Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmitryax @andrefrco