Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some skywalking tags, which should have been converted to attributes, were incorrectly converted to resource attributes #29731

Closed
h0cheung opened this issue Dec 11, 2023 · 3 comments
Assignees

Comments

@h0cheung
Copy link
Contributor

Component(s)

receiver/skywalking

What happened?

Description

Some tags, such as status_code (http.status_code in opentelemetry), are obviously span-level. But they are inserted into resource attributes after mapping.

This way, all spans in a segment have an http.status_code. If more than one span which has those attributes, they will be overridden again and again.

Steps to Reproduce

Expected Result

Actual Result

Collector version

50794af

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@h0cheung h0cheung added bug Something isn't working needs triage New item requiring triage labels Dec 11, 2023
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@JaredTan95 JaredTan95 self-assigned this Dec 13, 2023
@JaredTan95 JaredTan95 removed the needs triage New item requiring triage label Dec 13, 2023
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Feb 12, 2024
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants