Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opampsupervisor own metrics should support headers #30157

Closed
thmshmm opened this issue Dec 21, 2023 · 7 comments
Closed

opampsupervisor own metrics should support headers #30157

thmshmm opened this issue Dec 21, 2023 · 7 comments

Comments

@thmshmm
Copy link
Contributor

thmshmm commented Dec 21, 2023

Component(s)

cmd/opampsupervisor

Is your feature request related to a problem? Please describe.

Currently the supervisor only supports setting an endpoint for its own metrics. It should additionally support the headers provided via TelemetryConnectionSettings. This is needed to support e.g. authentication.

Describe the solution you'd like

The config could be a template and rendered with text/template to support more complex scenarios than single values.

Describe alternatives you've considered

No response

Additional context

No response

@thmshmm thmshmm added enhancement New feature or request needs triage New item requiring triage labels Dec 21, 2023
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@thmshmm
Copy link
Contributor Author

thmshmm commented Jan 3, 2024

feel free to assign it to me, i can work on it.

@crobert-1
Copy link
Member

Removing needs triage based on a code owner assigning the issue.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Feb 6, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Apr 8, 2024
@crobert-1 crobert-1 removed the Stale label Apr 8, 2024
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jun 10, 2024
@crobert-1 crobert-1 removed the Stale label Jun 10, 2024
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Aug 12, 2024
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants