Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkapi: ensure only exported structs end with Config #30467

Closed
atoulme opened this issue Jan 12, 2024 · 2 comments
Closed

checkapi: ensure only exported structs end with Config #30467

atoulme opened this issue Jan 12, 2024 · 2 comments
Labels
closed as inactive enhancement New feature or request needs triage New item requiring triage Stale

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 12, 2024

Component(s)

No response

Is your feature request related to a problem? Please describe.

The cmd/checkapi checks only check on functions right now.

Describe the solution you'd like

Add a check to make sure the only exported structs from a component are config structs. They should be suffixed with Config. Start by adding this expectation to best practices: https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md

Describe alternatives you've considered

No response

Additional context

No response

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed as inactive enhancement New feature or request needs triage New item requiring triage Stale
Projects
None yet
Development

No branches or pull requests

1 participant