-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checkapi
: ensure only exported structs end with Config
#30467
Comments
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
Component(s)
No response
Is your feature request related to a problem? Please describe.
The cmd/checkapi checks only check on functions right now.
Describe the solution you'd like
Add a check to make sure the only exported structs from a component are config structs. They should be suffixed with
Config
. Start by adding this expectation to best practices: https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.mdDescribe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: