Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/vcenter] add support for debug logging #30618

Closed
atoulme opened this issue Jan 16, 2024 · 6 comments
Closed

[receiver/vcenter] add support for debug logging #30618

atoulme opened this issue Jan 16, 2024 · 6 comments

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 16, 2024

Component(s)

receiver/vcenter

Is your feature request related to a problem? Please describe.

Similar to how the Smart Agent monitor for vSphere does it, we would like to have the possibility to get debug log when running the vCenter receiver.

Describe the solution you'd like

This is the implementation of LogProvider for the monitor:
https://github.com/signalfx/splunk-otel-collector/blob/main/internal/signalfx-agent/pkg/monitors/vsphere/service/log_provider.go
It's set here:
https://github.com/signalfx/splunk-otel-collector/blob/6abbb60ece21f1089227b09397e9abb01bdc236a/internal/signalfx-agent/pkg/monitors/vsphere/service/auth.go#L65

Describe alternatives you've considered

No response

Additional context

No response

@atoulme atoulme added enhancement New feature or request needs triage New item requiring triage labels Jan 16, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@djaglowski djaglowski removed the needs triage New item requiring triage label Jan 16, 2024
@hughesjj
Copy link
Contributor

I can pick this one up

@hughesjj
Copy link
Contributor

Not sure how useful the sfx implementation will be given the client we're using cannot be easily extended (unless we contribute upstream) and they have the notion of debugContainer available. Looks like they already save some responses in a similar fashion but to local files

Could I make a suggestion that we "better document how to debug and audit the vcenter receiver using existing configuration", or would you rather I try to poke some holes in the underlying soap client to wire up our own logger?

@hughesjj
Copy link
Contributor

Nevermind, that implementation seems to overwrite things a lot, and I erroneously thought we were setting the provider in the soapclient and not vim25 client. Back to doing what was originally proposed.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Mar 18, 2024
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants