Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iis.connection.anonymous should be iis.request.anonymous #30696

Closed
vijayaggarwal opened this issue Jan 21, 2024 · 6 comments
Closed

iis.connection.anonymous should be iis.request.anonymous #30696

vijayaggarwal opened this issue Jan 21, 2024 · 6 comments

Comments

@vijayaggarwal
Copy link

Component(s)

receiver/iis

What happened?

anonymous is a property of request and not of connection. Hence, the metric name should be iis.request.anonymous instead of iis.connection.anonymous.

Collector version

all recent versions

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@vijayaggarwal vijayaggarwal added bug Something isn't working needs triage New item requiring triage labels Jan 21, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@djaglowski djaglowski removed the needs triage New item requiring triage label Jan 22, 2024
@djaglowski
Copy link
Member

Since this would be a name change, we'll have to use a feature gate to toggle the metric name. Additional guidance here.

@vijayaggarwal
Copy link
Author

@djaglowski Thanks for the link to the guidance!

Another approach I can think of is to create a new metric iis.request.anonymous and mark iis.connection.anonymous deprecated as per the guidance on removing a default metric.

If this approach is acceptable, I will have a slight preference for this approach over the feature gate approach as I feel that transitioning will be simpler for users this way. That said, I leave the final decision to you as you know this better than I do.

@djaglowski
Copy link
Member

@vijayaggarwal, good suggestion. I think that's fine, as long as the new metric is marked optional.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Mar 25, 2024
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants