-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iis.connection.anonymous should be iis.request.anonymous #30696
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Since this would be a name change, we'll have to use a feature gate to toggle the metric name. Additional guidance here. |
@djaglowski Thanks for the link to the guidance! Another approach I can think of is to create a new metric If this approach is acceptable, I will have a slight preference for this approach over the feature gate approach as I feel that transitioning will be simpler for users this way. That said, I leave the final decision to you as you know this better than I do. |
@vijayaggarwal, good suggestion. I think that's fine, as long as the new metric is marked optional. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
Component(s)
receiver/iis
What happened?
anonymous
is a property of request and not of connection. Hence, the metric name should beiis.request.anonymous
instead ofiis.connection.anonymous
.Collector version
all recent versions
Environment information
No response
OpenTelemetry Collector configuration
No response
Log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: