-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle spans in the Loki exporter #3166
Comments
* kafka exporter: seperate message conversion for otlp and jaeger * fix test * fix format * Revert "fix format" This reverts commit f02e8fbb693b8b962916ee2999612e80c1c52bc7. * Revert "fix test" This reverts commit 23230cc11f2f6fb3dcca094127d66916000fbc44. * Revert "kafka exporter: seperate message conversion for otlp and jaeger" This reverts commit 418471881ac6bc919bf59163f0f04291e8991e7b. * convert traces/metrics/logs to sarama.ProducerMessage directly * fix linting error (impi) and changed CHANGELOG.md Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
@jean, I believe this is beyond the scope of the Loki exporter. Translating between Traces and Logs (or the other way around) is something that should be done at a different level, perhaps using the proposed "connectors" feature (cc @djaglowski). I'm closing this issue, but feel free to reopen if you think there's something specific about Loki that I'm not considering. cc @mar4uk |
@jpkrohling I'm fine with closing this. The better way is probably just to enable sending logs from the web client. |
Is your feature request related to a problem? Please describe.
I think that sending these as spans makes sense, since we want to send the full traces to e.g. Datadog as well, for analysis. (In fact the immediate reason for sending them as spans is that the web SDK doesn't support sending logs. That's coincidental, but may also be the case for other clients as noted in e.g. #3071.)
Describe the solution you'd like
Loki is format-agnostic, although it does support various parsers. A span serialized to JSON would work just fine.
Describe alternatives you've considered
Additional context
From @gramidt on slack:
In a case like this: is signal translation actually necessary? Could the
lokiexporter
just accept spans and send them through to Loki, pretending that they're logs?Transform logs to spans (PR WIP - #3003): #3071
The text was updated successfully, but these errors were encountered: