Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TLS in memcachedreceiver #31729

Closed
nitrotm opened this issue Mar 13, 2024 · 8 comments
Closed

Add support for TLS in memcachedreceiver #31729

nitrotm opened this issue Mar 13, 2024 · 8 comments
Labels

Comments

@nitrotm
Copy link

nitrotm commented Mar 13, 2024

Component(s)

receiver/memcached

Is your feature request related to a problem? Please describe.

When memcached is executed with --enable-ssl, the scraper must support TLS DialContext.

Describe the solution you'd like

Add the option to configure the TLS DialContext by adding new config settings. Probably the best is to embed the existing TLS config module

See here for a sample implementation when building a new memcache client (currently, the go dep is pointing to a fork of this project, but the fork lags behind in term of features).

Describe alternatives you've considered

No response

Additional context

No response

@nitrotm nitrotm added enhancement New feature or request needs triage New item requiring triage labels Mar 13, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@djaglowski
Copy link
Member

Makes sense to me. Will you make a PR @nitrotm?

@nitrotm
Copy link
Author

nitrotm commented May 13, 2024

do we know if that repo is still the best client implementation https://github.com/grobie/gomemcache?

sounds like the original author did some work since then (but still lacking the Stats command though):

This branch is 12 commits ahead of, 30 commits behind bradfitz/gomemcache:master.

@nitrotm
Copy link
Author

nitrotm commented May 13, 2024

that being said, grobie implementation has support for TLS, so maybe best to use that: grobie/gomemcache@331774f

@kernelpanic77
Copy link
Contributor

@nitrotm I'd like contribute as well, let me know if there is anything I can do.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants