Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure monitor exporter authentication #32163

Closed
arjunmahishi opened this issue Apr 4, 2024 · 5 comments
Closed

Azure monitor exporter authentication #32163

arjunmahishi opened this issue Apr 4, 2024 · 5 comments
Labels

Comments

@arjunmahishi
Copy link
Contributor

arjunmahishi commented Apr 4, 2024

Component(s)

exporter/azuremonitor

Is your feature request related to a problem? Please describe.

The current implementation of the Azure monitor exporter does not support EntraID based authentication out of the box. So, One has to use aad-auth-proxy along with OTel. This additional tool adds a bit of maintenance overhead.

Describe the solution you'd like

Are there any plans to add support for EntraID based auth in the future?

If not, can the exporter use an HTTP client created using the confighttp package instead of a default HTTP client? A lot of other exporters seem to be doing this. This will allow us to create an auth extension with the capabilities of aad-auth-proxy. I think a lot of users would prefer using an extension instead of deploying a whole other tool.

Describe alternatives you've considered

No response

Additional context

The confighttp's HTTP client can be injected somewhere here perhaps

telemetryConfiguration := appinsights.NewTelemetryConfiguration(string(exporterConfig.InstrumentationKey))
telemetryConfiguration.EndpointUrl = exporterConfig.Endpoint
telemetryConfiguration.MaxBatchSize = exporterConfig.MaxBatchSize
telemetryConfiguration.MaxBatchInterval = exporterConfig.MaxBatchInterval
telemetryClient := appinsights.NewTelemetryClientFromConfig(telemetryConfiguration)

@arjunmahishi arjunmahishi added enhancement New feature or request needs triage New item requiring triage labels Apr 4, 2024
Copy link
Contributor

github-actions bot commented Apr 4, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@arjunmahishi
Copy link
Contributor Author

Hi @arjunmahishi does this solve the issue

https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/azuremonitorexporter/AUTHENTICATION.md#aadentra-authentication

No it does not. This is what is currently possible. My post is about asking for a better alternative.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants