-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deltatocumulative: Number of buckets in exponential histograms should be capped #33277
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
#34157 should address it, we've been using it in production for over a month. Can someone please review? |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This problem is still relevant and we would not be able to use deltatocumulative in production without #34157. @sh0rez @RichieSams @jpkrohling please review 😄 |
Component(s)
processor/deltatocumulative
What happened?
Description
Currently size of an individual histogram is unbounded and can grow until OOM is reached.
This is prominent if an application has large distribution of data overall but only relatively small in an individual delta datapoint. In this case cumulative aggregation keeps the scale but keeps growing number of buckets to fit all the data.
Steps to Reproduce
Send two histogram datapoints with the same scale but drastically different offsets.
Expected Result
Cumulative exponential histogram is downscaled to keep around ≈160 buckets.
Actual Result
Exponential histogram grows number of buckets instead, leading to OOM.
Collector version
v0.101.0
Environment information
Environment
OS: Linux
Compiler(if manually compiled): go 1.22.2
OpenTelemetry Collector configuration
No response
Log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: