Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a common utils to call k8s api server #3424

Closed
pxaws opened this issue May 18, 2021 · 4 comments
Closed

Need a common utils to call k8s api server #3424

pxaws opened this issue May 18, 2021 · 4 comments

Comments

@pxaws
Copy link
Contributor

pxaws commented May 18, 2021

Is your feature request related to a problem? Please describe.
Existing otel components contain some duplicate functionalities for calling the kubernetes api server:

In addition, the AWS Container Insights project is also introducing another way to call the kubernetes api server through a lower-level cache.reflector api: #3367. Unlike Kubernetes informers that automatically maintain all the resource metadata in cache, cache.reflector requires you to manage your own cache. So you can selectively keep only the things that are really needed. This is beneficial as we want to keep the memory usage as small as possible especially when you are monitoring a big cluster with a large number of different resources (e.g. pod, node, job, endpoint, service ...)

Describe the solution you'd like
The duplicate functionalities doesn't seems to be a big issue at this moment. But as more receivers/processors begin to call k8s api server in the future, there is a need to provide a common k8s util for code reuse. I think the ideas is to provide at least two set of apis (one using kubernetes informers and one using cache.reflector). To design an easy-to-use and extendable k8s utils seems to be a big effort and will involve owners of multiple otel components. I don't imagine that this can be done in a short time. So I am proposing that we use the current feature request to track the relevant discussions and plans.

For now, we still want to merge the PR into a aws internal folder for Container Insight usage due to the project timeline. But we are happy to discuss any refactoring about the code to make it also useful for other otel components.

@pxaws
Copy link
Contributor Author

pxaws commented May 18, 2021

@alolita @mxiamxia

@pxaws pxaws changed the title A common utils to call k8s api server Need a common utils to call k8s api server May 18, 2021
alexperez52 referenced this issue in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
As discussed during the SIG, we want to move storage extension to core, starting with the interface (this PR) so persistent buffer implementation (open-telemetry/opentelemetry-collector#2285) could use it

**Link to tracking Issue:** #3424 

**Testing:** Just the interface, no tests

**Documentation:** README.md with API

cc @djaglowski @tigrannajaryan
@alolita alolita added the comp:aws AWS components label Sep 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 4, 2022
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants