[filestorage] - Add directory validation for compaction on-rebound #35114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauri870
reviewed
Sep 10, 2024
| { | ||
| name: "directory-must-exists-error", | ||
| validate: func(t *testing.T) { | ||
| f := NewFactory() |
There was a problem hiding this comment.
Most of the validate function body is the same for every test, do you think it is worth to refactor it so that tests is a []struct {name string; config *Config; err error } or similar?
There was a problem hiding this comment.
Thanks, I've refactored them, but we still need to call CreateDefaultConfig() since some of the fields, while not relevant to this test, are still required.
mauri870
approved these changes
Sep 10, 2024
djaglowski
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, we only verify the existence of the compaction directory when
compaction.on_startis enabled. This check should also be performed whencompaction.on_reboundis enabled.Otherwise, we encounter continuous error notifications due to the directory not existing, which results in compaction failures.
Testing: Added