Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers Setter Extension Filtering Functionality #35276

Open
kyo-ke opened this issue Sep 18, 2024 · 7 comments
Open

Headers Setter Extension Filtering Functionality #35276

kyo-ke opened this issue Sep 18, 2024 · 7 comments
Labels

Comments

@kyo-ke
Copy link

kyo-ke commented Sep 18, 2024

Component(s)

extension/headerssetter

Is your feature request related to a problem? Please describe.

if new tenantID come to Tempo, it will automatically create tenant for that ID.
We want to allow only specific format for tenantID and avoid creating random tenant.

Describe the solution you'd like

Cerate filtering feature using regular expression on headers setter extension.
only matching tenantID is pushed to Tempo.

Describe alternatives you've considered

No response

Additional context

No response

@kyo-ke kyo-ke added enhancement New feature or request needs triage New item requiring triage labels Sep 18, 2024
Copy link
Contributor

Pinging code owners for extension/headerssetter: @jpkrohling. See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme
Copy link
Contributor

atoulme commented Dec 7, 2024

Is there a way around this by using the transform processor to drop data if the tenant is not matching? @jpkrohling please review.

@kyo-ke
Copy link
Author

kyo-ke commented Dec 11, 2024

In my understanding transform processor is for modifying telemetry and tenantID is in header so we cannot use it for this scenario

@atoulme
Copy link
Contributor

atoulme commented Dec 11, 2024

Yes, you're correct. I don't know how to manipulate context headers.

@kyo-ke
Copy link
Author

kyo-ke commented Dec 13, 2024

is it OK to create PR for this feature?

@jpkrohling
Copy link
Member

This would likely be a good candidate for our middleware extensions: open-telemetry/opentelemetry-collector#7441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants