Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Fetching Custom Instance Labels in GCP Resource Detection Processor #35859

Open
navaneeth-c opened this issue Oct 17, 2024 · 3 comments
Labels
enhancement New feature or request processor/resourcedetection Resource detection processor

Comments

@navaneeth-c
Copy link

navaneeth-c commented Oct 17, 2024

Component(s)

processor/resourcedetectionprocessor

Is your feature request related to a problem? Please describe.

Yes, the current resourcedetection processor in the OpenTelemetry Collector does not support fetching custom instance labels (tags) from Google Cloud Platform (GCP) Compute Engine (GCE) instances. This limitation hinders our ability to enrich telemetry data with valuable metadata that is critical for observability, monitoring, and consistent tagging strategies across multi-cloud environments.

Describe the solution you'd like

I propose enhancing the GCP (GCE) detector within the resourcedetection processor to fetch custom instance labels from GCE instances. The implementation would be similar to how the EC2 and Azure detectors retrieve custom tags. The solution includes:

  • Configuration Support: Introduce a new configuration option under the GCP detector to enable fetching of custom labels.
processors:
  resourcedetection:
    detectors: [gcp]
    gcp:
      labels:
        enabled: true
        # List of regex patterns to include specific labels
        include:
          - ".*"  # Include all labels
          - "^env$"  # Include the 'env' label
          - "^team.*$"  # Include labels starting with 'team'

Describe alternatives you've considered

No response

Additional context

Thank you for considering this feature request.

@navaneeth-c navaneeth-c added enhancement New feature or request needs triage New item requiring triage labels Oct 17, 2024
@navaneeth-c
Copy link
Author

/label processor/resourcedetectionprocessor

@atoulme atoulme added processor/resourcedetection Resource detection processor and removed needs triage New item requiring triage labels Nov 9, 2024
Copy link
Contributor

github-actions bot commented Nov 9, 2024

Pinging code owners for processor/resourcedetection: @Aneurysm9 @dashpole. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dashpole
Copy link
Contributor

This makes sense to me. cc @aabmass @psx95 @jsuereth

I'm happy to review PRs to implement this in the resource detector.

I assume we would be able to share the same configuration as the azure and aws detectors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request processor/resourcedetection Resource detection processor
Projects
None yet
Development

No branches or pull requests

3 participants