Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing k8sattributesprocessor for Multi-Dimensional Metrics Collection #36437

Open
tomatopunk opened this issue Nov 19, 2024 · 4 comments
Open
Labels
enhancement New feature or request needs triage New item requiring triage processor/k8sattributes k8s Attributes processor

Comments

@tomatopunk
Copy link

Component(s)

processor/k8sattributes

Is your feature request related to a problem? Please describe.

Currently, the k8sattributesprocessor retrieves the pod identifier value from a single resource attribute. However, in many scenarios, this is not sufficient.

For example, while the collection target might be a node or machine, the metrics collected could be at the container level or related to specific Kubernetes resources, such as pods, containers, or even PVs and PVCs, as seen with tools like google/cAdvisor and kubelet.

Describe the solution you'd like

We need to add an attribute scope before inserting metadata, such as labels or container IDs.
By introducing this attribute scope, we can prioritize resource attribute scopes effectively.

Describe alternatives you've considered

No response

Additional context

No response

@tomatopunk tomatopunk added enhancement New feature or request needs triage New item requiring triage labels Nov 19, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the processor/k8sattributes k8s Attributes processor label Nov 19, 2024
@tomatopunk
Copy link
Author

@dmitryax @fatsheep9146 @TylerHelmuth
What do you think? I'm really excited to complete this feature.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jan 20, 2025
@ChrsMark
Copy link
Member

If understand this correctly, the proposal is to add support for associating metrics with other resources like Nodes? I think this request makes sense.

i.e.: kubeletstats receiver can provide Node's cpu metrics. We want these metrics to be populated with additional K8s metadata from the processor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage New item requiring triage processor/k8sattributes k8s Attributes processor
Projects
None yet
Development

No branches or pull requests

2 participants