-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/ottl] remove support from accessing top-level objects #36872
[pkg/ottl] remove support from accessing top-level objects #36872
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although it's not a breaking change, I'm wondering if we should have a change log for that, so users with this kind of no op statements would know why their configurations started to fail. If you think that's not needed, LGTM!
I think we need a changelog entry documenting this as a breaking change, but maybe I'm missing something. I was able to get the following statement to work:
I can't come up with any real uses for this, but it does parse. Honestly, given that it's so unhelpful, I'm tempted to even say we could call this a bug fix. |
It works when you're reaching up, but not when you're in the context itself. So
works but
does not. I am ok calling this a bug_fix or a breaking change. |
Description
Removes the path accessors for the shared contexts that allowed getting top level objects for:
While these accessors existed the grammar didn't actually let you use them and their presence makes future work problematic. At this time we don't want to provide accessors to entire parent objects directly.
Link to tracking issue
Related to #36869