[pkg/stanza] Add 'regex_replace' operator #37443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjasny
force-pushed
the
strip-ansi-escape-codes
branch
from
b32fac5 to
411655a
Compare
atoulme
previously approved these changes
Jan 24, 2025
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@djaglowski Could you please take a look? I used mostly the "unquote" operator as a blueprint. So there should not be any surprises. Thanks! |
djaglowski
reviewed
Feb 12, 2025
pkg/stanza/operator/transformer/stripansiescapecodes/transformer.go
Outdated
Show resolved
Hide resolved
gjasny
force-pushed
the
strip-ansi-escape-codes
branch
from
411655a to
0af4984
Compare
gjasny
commented
Mar 6, 2025
djaglowski
reviewed
Mar 7, 2025
djaglowski
approved these changes
Mar 7, 2025
djaglowski
changed the title
gjasny
added a commit
to gjasny/opentelemetry-collector-contrib
that referenced
this pull request
Mar 8, 2025
This is a follow-up to issue open-telemetry#37443.
gjasny
added a commit
to gjasny/opentelemetry-collector-contrib
that referenced
this pull request
Mar 8, 2025
This is a follow-up from open-telemetry#37443. It extracts the test logic for operator build errors into re-useable methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We use the filelog receiver to ingest Artifactory logs. Some but not all of them contain ANSI color sequences. This makes regex creation pretty uncomfortable because both: log field separators and the ANSI color codes contain
[characters.I was first thinking about using the
addoperator and removing the regex within theEXPR(). But I could not find any suitable regex function which works within that expression.I could imagine that I'm not the only one who would like to get rid of colors. Therefore I believe that an easy to use operator enhances readability of the pipeline and is less error-prone than a (potentially) hand-crafted regex.
Testing
Added unit tests and tested locally against Artifactory log files.