Skip to content

Conversation

@Nabil-Salah
Copy link
Contributor

Description

Link to tracking issue

jaegertracing/jaeger#6494

Testing

go test

Documentation

Signed-off-by: nabil salah <nabil.salah203@gmail.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 7, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@Nabil-Salah
Copy link
Contributor Author

Nabil-Salah commented Feb 7, 2025

@yurishkuro
should i also update proto-gen , thrift-gen in same pr?

@yurishkuro
Copy link
Member

Yes

@Nabil-Salah
Copy link
Contributor Author

@yurishkuro
can you give workflow approval

@crobert-1
Copy link
Member

Hello @Nabil-Salah, thanks for your contribution! To be able to move this PR forward, please sign the CLA. 👍

@Nabil-Salah Nabil-Salah marked this pull request as ready for review February 7, 2025 23:20
@Nabil-Salah Nabil-Salah requested a review from a team as a code owner February 7, 2025 23:20
@Nabil-Salah
Copy link
Contributor Author

hello @crobert-1 i signed it now :D

@Nabil-Salah Nabil-Salah changed the title Update Jaeger model import paths to use jaeger-idl v1 [chore] Update Jaeger model import paths to use jaeger-idl v1 Feb 7, 2025
Signed-off-by: nabil salah <nabil.salah203@gmail.com>
@Nabil-Salah
Copy link
Contributor Author

can you run the workflow once again :D @yurishkuro @crobert-1

@yurishkuro
Copy link
Member

@Nabil-Salah while waiting for the merge, can you analyze what the remaining dependencies on /jaeger/ there are? I've seen while doing a review some remaining direct dependencies and curiously some indirect ones.

@Nabil-Salah
Copy link
Contributor Author

@yurishkuro
Copy link
Member

I came up with this report

thanks. I left a bunch of comments, seems like it still needs a decent amount of clean-up. Breaking dependency on the agent code would be the largest impact (Jaeger no longer uses agent code, we only kept it because of this dependency).

@yurishkuro yurishkuro added the ready to merge Code review completed; ready to merge by maintainers label Feb 9, 2025
@songy23 songy23 merged commit 55ca3c5 into open-telemetry:main Feb 10, 2025
173 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 10, 2025
@yurishkuro
Copy link
Member

🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants