-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
confighttp.ToServer should be setting ErrorLog #11820
Comments
@yurishkuro hey can i take this up |
feel free |
@yurishkuro
|
there is no need for new options - the ToServer function already receives a logger via telemetry settings. It can just assign ErrorLogger. |
So you mean to say the Error Logger Should always be Zap.logger and the client should not get any option to give his own logger? |
yes. It's a bug fix, not a capability. |
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Is your feature request related to a problem? Please describe.
Standard
http.Server
has a fieldErrorLog
:However,
confighttp.ToServer
leaves it empty, which will lead to error logs printed using a different logger.Describe the solution you'd like
In Jaeger we initialize it with a logger backed by Zap:
I think
confighttp.ToServer()
should do the same.The text was updated successfully, but these errors were encountered: