Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup initialization order for exporterhelper #12239

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Feb 1, 2025

Also, this PR fixes a concurrency data issue that only affects users that manually turned on exporter.UsePullingBasedExporterQueueBatcher featuregate.

exporter.UsePullingBasedExporterQueueBatcher is still alpha in the last release.

@bogdandrutu bogdandrutu requested review from dmitryax and a team as code owners February 1, 2025 22:04
@bogdandrutu bogdandrutu force-pushed the clenup-initialization branch from f278630 to 97275e8 Compare February 1, 2025 22:12
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu force-pushed the clenup-initialization branch from 97275e8 to dfa9a23 Compare February 1, 2025 22:13
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 89.15663% with 9 lines in your changes missing coverage. Please review.

Project coverage is 91.29%. Comparing base (5f95f72) to head (dfa9a23).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
exporter/exporterhelper/internal/base_exporter.go 94.44% 2 Missing and 1 partial ⚠️
exporter/exporterhelper/internal/queue_sender.go 72.72% 2 Missing and 1 partial ⚠️
exporter/exporterhelper/internal/request_sender.go 40.00% 2 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (89.15%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12239      +/-   ##
==========================================
- Coverage   91.31%   91.29%   -0.03%     
==========================================
  Files         465      465              
  Lines       25654    25662       +8     
==========================================
+ Hits        23427    23429       +2     
- Misses       1814     1818       +4     
- Partials      413      415       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@bogdandrutu bogdandrutu added this pull request to the merge queue Feb 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 1, 2025
@bogdandrutu bogdandrutu added this pull request to the merge queue Feb 1, 2025
Merged via the queue into open-telemetry:main with commit aac0a30 Feb 1, 2025
53 of 54 checks passed
@bogdandrutu bogdandrutu deleted the clenup-initialization branch February 1, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants