You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
The current implementation of samplingprocessor calls nextConsumer.ConsumeTraces once per received batch of spans. Spans arriving from different services would necessarily be in separate batches. I'd like nextConsumer.ConsumeTraces to be invoked once, with all the spans for a given trace. This would allow downstream processors to operate on the entire trace.
Is your feature request related to a problem? Please describe.
The current implementation of
samplingprocessor
callsnextConsumer.ConsumeTraces
once per received batch of spans. Spans arriving from different services would necessarily be in separate batches. I'd likenextConsumer.ConsumeTraces
to be invoked once, with all the spans for a given trace. This would allow downstream processors to operate on the entire trace.Describe the solution you'd like
The samplingprocessor already has all spans available, the change would be minimal, instead of invoking
ConsumeTraces
in a loop here https://github.com/open-telemetry/opentelemetry-collector/blob/master/processor/samplingprocessor/tailsamplingprocessor/processor.go#L183-L185 the processor would create a newpdata.Traces
and add all spans to it.Conceptually this is similar to how the groupbytrace processor works.
If this is ok, I can submit a pr for it.
The text was updated successfully, but these errors were encountered: