Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning about IsNil, this function no-longer exists #2518

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Feb 20, 2021

Updates #2488

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested a review from a team February 20, 2021 17:03
@codecov
Copy link

codecov bot commented Feb 20, 2021

Codecov Report

Merging #2518 (38f4256) into main (379645d) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2518      +/-   ##
==========================================
+ Coverage   91.71%   91.73%   +0.01%     
==========================================
  Files         265      265              
  Lines       15083    15092       +9     
==========================================
+ Hits        13834    13845      +11     
+ Misses        867      866       -1     
+ Partials      382      381       -1     
Impacted Files Coverage Δ
consumer/pdata/generated_common.go 100.00% <ø> (ø)
consumer/pdata/generated_log.go 100.00% <ø> (ø)
consumer/pdata/generated_metrics.go 100.00% <ø> (ø)
consumer/pdata/generated_resource.go 100.00% <ø> (ø)
consumer/pdata/generated_trace.go 100.00% <ø> (ø)
...internal/scraper/processscraper/process_scraper.go 98.13% <0.00%> (-0.02%) ⬇️
config/confighttp/confighttp.go 100.00% <0.00%> (ø)
...internal/scraper/networkscraper/network_scraper.go 97.91% <0.00%> (ø)
...nal/scraper/pagingscraper/paging_scraper_others.go 100.00% <0.00%> (ø)
...al/scraper/filesystemscraper/filesystem_scraper.go 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 347cfa9...3337b70. Read the comment docs.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@tigrannajaryan tigrannajaryan merged commit 92f1cac into open-telemetry:main Feb 22, 2021
@bogdandrutu bogdandrutu deleted the isnil branch February 22, 2021 21:07
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…y#2518)

Bumps [boto3](https://github.com/boto/boto3) from 1.26.54 to 1.26.59.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.26.54...1.26.59)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants