Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom opencensus sematic conventions with otel semantic conventions #2552

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested a review from a team February 25, 2021 18:51
@bogdandrutu bogdandrutu force-pushed the rmocconv branch 2 times, most recently from 86fa415 to e0e410e Compare February 26, 2021 18:08
@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #2552 (d91f657) into main (3e138d7) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2552      +/-   ##
==========================================
+ Coverage   91.89%   92.03%   +0.14%     
==========================================
  Files         270      270              
  Lines       15420    15425       +5     
==========================================
+ Hits        14170    14197      +27     
+ Misses        868      847      -21     
+ Partials      382      381       -1     
Impacted Files Coverage Δ
internal/goldendataset/span_generator.go 98.30% <100.00%> (+0.01%) ⬆️
translator/internaldata/oc_to_resource.go 100.00% <100.00%> (ø)
translator/internaldata/oc_to_traces.go 90.21% <100.00%> (+3.87%) ⬆️
translator/internaldata/resource_to_oc.go 93.93% <100.00%> (ø)
translator/internaldata/traces_to_oc.go 93.86% <100.00%> (+7.07%) ⬆️
translator/trace/zipkin/zipkinv2_to_traces.go 89.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e138d7...d91f657. Read the comment docs.

…entions

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 27b27b7 into open-telemetry:main Mar 2, 2021
@bogdandrutu bogdandrutu deleted the rmocconv branch March 2, 2021 03:07
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants