Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SetConsumerError from sink test helpers #2579

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

bogdandrutu
Copy link
Member

Fixes #2477

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested a review from a team March 2, 2021 23:08
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #2579 (f50ba54) into main (44a8a09) will decrease coverage by 0.00%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2579      +/-   ##
==========================================
- Coverage   92.02%   92.02%   -0.01%     
==========================================
  Files         273      274       +1     
  Lines       15444    15455      +11     
==========================================
+ Hits        14213    14222       +9     
- Misses        849      850       +1     
- Partials      382      383       +1     
Impacted Files Coverage Δ
consumer/consumertest/sink.go 100.00% <ø> (ø)
...ernal/internalconsumertest/err_or_sink_consumer.go 90.00% <90.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44a8a09...f50ba54. Read the comment docs.

@bogdandrutu bogdandrutu changed the title Remove SetConsumerError from sink helpers Remove SetConsumerError from sink test helpers Mar 3, 2021
@bogdandrutu bogdandrutu force-pushed the fixconstest branch 2 times, most recently from bbcc8c8 to f7deaca Compare March 8, 2021 18:55
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fixes open-telemetry#2477

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 98a0672 into open-telemetry:main Mar 8, 2021
@bogdandrutu bogdandrutu deleted the fixconstest branch March 8, 2021 19:41
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and improve consumertest package
2 participants