Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify builders for components, remove unnecessary builders #2624

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested a review from a team March 8, 2021 19:26
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #2624 (56332a0) into main (44a8a09) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2624   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files         273      273           
  Lines       15444    15444           
=======================================
  Hits        14213    14213           
  Misses        849      849           
  Partials      382      382           
Impacted Files Coverage Δ
service/builder/exporters_builder.go 81.73% <100.00%> (ø)
service/builder/extensions_builder.go 80.76% <100.00%> (ø)
service/builder/pipelines_builder.go 88.42% <100.00%> (ø)
service/builder/receivers_builder.go 72.13% <100.00%> (ø)
service/service.go 52.67% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44a8a09...56332a0. Read the comment docs.

@tigrannajaryan
Copy link
Member

I think we can move entire builder package to internal. I don't think it should be public API for us.

@bogdandrutu bogdandrutu merged commit d9099c5 into open-telemetry:main Mar 8, 2021
@bogdandrutu bogdandrutu deleted the servicebuilder branch March 8, 2021 20:19
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants