-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different uses of timeout
on exporters
#4497
Comments
@MovieStoreGuy, this would be a good entry to add to the doc you are creating. |
Yeah, I remember seeing this in the kafka exporter and thought it was strange. I do think I like the idea of option 1 though, having |
@codeboten, are you able to summarize what was discussed yesterday? I had Zoom problems and missed part of the discussion. |
Hey @codeboten , Was there more to add to this please? |
The
exporterhelper
includes a timeout mechanism, which is enabled by default (see #4455 for more on that), and sets a timeout for the wholeConsume[Metrics/Traces/Logs]
function call. Several exporters in contrib however rely on Go's HTTP client timeout instead (1, 2, 3, 4, 5), while still using the sametimeout
option.This is an issue to discuss:
exporterhelper.TimeoutSettings
and use a custom timeout field instead?This was originally brought up by @codeboten at open-telemetry/opentelemetry-collector-contrib#6414 (comment). For context, in our exporter we don't rely on the global timeout mechanism because we need to do several network calls on a single
Consume
call and want to timeout on each specific call instead.The text was updated successfully, but these errors were encountered: