Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Add shellcheck linter #6864

Closed
mx-psi opened this issue Dec 28, 2022 · 4 comments
Closed

[ci] Add shellcheck linter #6864

mx-psi opened this issue Dec 28, 2022 · 4 comments
Assignees
@noelukwa
Labels
ci-cd CI, CD, testing, build issues enhancement New feature or request github_actions Pull requests that update Github_actions code good first issue Good for newcomers priority:p2 Medium

Comments

@mx-psi
Copy link
Member

mx-psi commented Dec 28, 2022

shellcheck is a static analysis tool for identifying issues on shell scripts. It's generally good for enforcing idiomatic and sensible shell scripts.

To ensure we continously lint our scripts with shellcheck, we should add a Github workflow that lints our shell scripts with shellcheck and fixes the issues pointed out by the command above.

See also open-telemetry/opentelemetry-collector-contrib/issues/17279 and open-telemetry/opentelemetry-collector-releases/issues/264 for similar issues on contrib and releases.
@mx-psi mx-psi added enhancement New feature or request good first issue Good for newcomers priority:p2 Medium github_actions Pull requests that update Github_actions code ci-cd CI, CD, testing, build issues labels Dec 28, 2022
@PiotrLewandowski323 PiotrLewandowski323 mentioned this issue Dec 31, 2022
Merged
@noelukwa
Copy link

@mx-psi I want to give this a shot.

@mx-psi
Copy link
Member Author

mx-psi commented Jan 3, 2023

Assigned to you @noelukwa, thanks!

@noelukwa noelukwa mentioned this issue Jan 3, 2023
Closed
@pirgeo
Copy link
Member

pirgeo commented Feb 8, 2023

I guess this can be marked as done due to #6870 being merged, right?

@mx-psi
Copy link
Member Author

mx-psi commented Feb 8, 2023

Indeed, thanks for catching this @pirgeo, closing...

@mx-psi mx-psi closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noelukwa noelukwa

Labels
ci-cd CI, CD, testing, build issues enhancement New feature or request github_actions Pull requests that update Github_actions code good first issue Good for newcomers priority:p2 Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mx-psi @noelukwa @pirgeo