Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark tags to bazel targets #1072

Closed
hcoona opened this issue Nov 16, 2021 · 1 comment · Fixed by #1075 or #1094
Closed

Mark tags to bazel targets #1072

hcoona opened this issue Nov 16, 2021 · 1 comment · Fixed by #1075 or #1094

Comments

@hcoona
Copy link
Contributor

hcoona commented Nov 16, 2021

Is your feature request related to a problem?

The project could build with GCC4.8 + CMake but failed to build with GCC4.8+Bazel. I cannot understand it although I know the higher version of GRPC could not compile with GCC4.8.

I think most of the core components rely on nothing than some extremely basic libraries such as abseil, gsl, gtest & google benchmark. We at least should support bazel build for these targets.

Describe the solution you'd like

I'd like to mark the bazel targets with tags, so we can easily to exclude some components. For example, excluding OTLP would significantly simplify dependencies.

** Example **

cc_test(
    name = "otlp_recordable_test",
    srcs = ["test/otlp_recordable_test.cc"],
    deps = [
        ":otlp_recordable",
        "@com_google_googletest//:gtest_main",
    ],
    tags = ["otlp"],
)
bazel build //... --build_tag_filters=-otlp
@lalitb
Copy link
Member

lalitb commented Nov 17, 2021

Thanks for bringing this up.

Bazel build for GCC4.8 was disabled in this PR once grpc and bazel version was upgraded. As you rightly mentioned higher version of gRPC doesn't compile with gcc4.8.

For CMake, we use the latest gRPC version for > gcc5.1 and older compatible gRPC version for gcc4.8 as done in this PR

Though I am not a bazel expert ( and we are missing expertise for that in the forum ), your approach for being able to choose/exclude the bazel target based on the platform looks a good approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants