Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logger: Support for Instrumentation library. #1087

Closed
lalitb opened this issue Nov 22, 2021 · 3 comments · Fixed by #1149
Closed

Logger: Support for Instrumentation library. #1087

lalitb opened this issue Nov 22, 2021 · 3 comments · Fixed by #1149
Assignees
@esigo
Labels
good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers

Comments

@lalitb
Copy link
Member

lalitb commented Nov 22, 2021 •
edited
Loading

  1. Updating loggerProvider::GetLogger() in API and SDK for optional schema_url parameter.
  2. Add Instrumentation Library support as for trace implementation:

    opentelemetry-cpp/sdk/src/trace/tracer_provider.cc

    Line 39 in 089b04d

    nostd::shared_ptr<trace_api::Tracer> TracerProvider::GetTracer(
  3. Propagate instrumentation library to the exporter through recordable interface ( adding Recordable::SetInstrumentationLibrary() ) method.
@lalitb lalitb added help wanted Good for taking. Extra help will be provided by maintainers good first issue Good for newcomers labels Nov 22, 2021
@esigo
Copy link
Member

esigo commented Dec 8, 2021

1 shouldn't be loggerProvider::GetLogger()?

@lalitb
Copy link
Member Author

lalitb commented Dec 8, 2021

yes thanks. fixed now.

@esigo
Copy link
Member

esigo commented Dec 8, 2021

could you please assign it to me? thanks

@esigo esigo mentioned this issue Dec 10, 2021
Closed
3 tasks
@esigo esigo mentioned this issue Dec 18, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esigo esigo

Labels
good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers
Projects
None yet
Milestone
No milestone
2 participants
@lalitb @esigo