Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake install misses a header #1272

Closed
VivekSubr opened this issue Mar 20, 2022 · 0 comments · Fixed by #1273 or #1419
Closed

cmake install misses a header #1272

VivekSubr opened this issue Mar 20, 2022 · 0 comments · Fixed by #1273 or #1419
Labels
bug Something isn't working

Comments

@VivekSubr
Copy link

Describe your environment
Ubuntu, wsl

Steps to reproduce
Install steps,
mkdir build && cd build
cmake .. -DBUILD_SHARED_LIBS=ON -DWITH_JAEGER=ON
cmake --build . --target all
ctest
cmake --install . --config Release --prefix ../.

What is the expected behavior?
The include directory should be as per cmake OPENTELEMETRY_CPP_INCLUDE_DIRS by default, and it should contain all relevant header files.

What is the actual behavior?
If --prefix not given it installs in same folder.

header "opentelemetry/sdk_config.h" is not copied.

Additional context
Usually code compiles fine, until you include a file that depends on sdk_config.h in an header, like
#include "opentelemetry/exporters/memory/in_memory_span_exporter.h"

@VivekSubr VivekSubr added the bug Something isn't working label Mar 20, 2022
@esigo esigo mentioned this issue Mar 20, 2022
3 tasks
@flier flier mentioned this issue Jun 1, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant