”cmake_minimum_required(VERSION 3.1)“ is inaccurate

[GskFID]

There are many places to add tests with ”gtest_add_tests“, But gtest_add_tests is a new feature of Cmake 3.9 version, When I try to compile with 3.8.5, it doesn't compile the test code anyway, this confused me for a while.

[lalitb]

Good point. We should -

• Either not use gtest_add_tests() to add unit tests. (preferably)
• Or make the minimum required cmake version as 3.9.

[esigo]

old cmake compatible example can be found here:

opentelemetry-cpp/sdk/test/trace/CMakeLists.txt

Lines 1 to 30 in 521ebd8

	foreach(
	testname
	tracer_provider_test
	span_data_test
	simple_processor_test
	tracer_test
	always_off_sampler_test
	always_on_sampler_test
	parent_sampler_test
	trace_id_ratio_sampler_test
	batch_span_processor_test)
	add_executable(${testname} "${testname}.cc")
	target_link_libraries(
	${testname}
	${GTEST_BOTH_LIBRARIES}
	${CMAKE_THREAD_LIBS_INIT}
	opentelemetry_common
	opentelemetry_trace
	opentelemetry_resources
	opentelemetry_exporter_in_memory)
	gtest_add_tests(
	TARGET ${testname}
	TEST_PREFIX trace.
	TEST_LIST ${testname})
	endforeach()
	add_executable(sampler_benchmark sampler_benchmark.cc)
	target_link_libraries(
	sampler_benchmark benchmark::benchmark ${CMAKE_THREAD_LIBS_INIT}
	opentelemetry_trace opentelemetry_resources opentelemetry_exporter_in_memory)

[lalitb]

old cmake compatible example can be found here:

opentelemetry-cpp/sdk/test/trace/CMakeLists.txt

Lines 1 to 30 in 521ebd8

	foreach(
	testname
	tracer_provider_test
	span_data_test
	simple_processor_test
	tracer_test
	always_off_sampler_test
	always_on_sampler_test
	parent_sampler_test
	trace_id_ratio_sampler_test
	batch_span_processor_test)
	add_executable(${testname} "${testname}.cc")
	target_link_libraries(
	${testname}
	${GTEST_BOTH_LIBRARIES}
	${CMAKE_THREAD_LIBS_INIT}
	opentelemetry_common
	opentelemetry_trace
	opentelemetry_resources
	opentelemetry_exporter_in_memory)
	gtest_add_tests(
	TARGET ${testname}
	TEST_PREFIX trace.
	TEST_LIST ${testname})
	endforeach()
	add_executable(sampler_benchmark sampler_benchmark.cc)
	target_link_libraries(
	sampler_benchmark benchmark::benchmark ${CMAKE_THREAD_LIBS_INIT}
	opentelemetry_trace opentelemetry_resources opentelemetry_exporter_in_memory)

This example seems to be using gtest_add_tests at line 21, or am I missing something ?

[owent]

I vote for upgrade the minimum version of cmake.It will be easier to maintain.

[esigo]

@lalitb sorry I was wrong, we have no example for the old Cmake version.
I agree with @owent, I'd vote for upgrading the minimum required cmake.

[lalitb]

To see if we can use the gtest_add_tests() function from cmake module:
https://github.com/Kitware/CMake/blob/908d2cd136be3165d391c18777890798a18f96c3/Modules/GoogleTest.cmake#L293-L294

[lalitb]

There are few more cmake constructs in code not supported in cmake v3.1.0:

opentelemetry-cpp/CMakeLists.txt

Line 9 in a847d0c

if(${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.12")

opentelemetry-cpp/ext/test/http/CMakeLists.txt

Line 4 in 76c664a

add_compile_definitions(WITH_CURL)

[owent]

There are few more cmake constructs in code not supported in cmake v3.1.0:

opentelemetry-cpp/CMakeLists.txt

Line 9 in a847d0c

if(${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.12")

opentelemetry-cpp/ext/test/http/CMakeLists.txt

Line 4 in 76c664a

add_compile_definitions(WITH_CURL)

I think add_compile_definitions(WITH_CURL) can be removed now.

[github-actions]

This issue was marked as stale due to lack of activity.