Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ETW exporter from opentelelemetry-cpp to opentelemetry-cpp-contrib #1423

Open
lalitb opened this issue Jun 2, 2022 · 3 comments
Open
Labels
do-not-stale good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers issue:blocking This issue is preventing other fixes

Comments

@lalitb
Copy link
Member

lalitb commented Jun 2, 2022

As per the specs only Zipkin, OTLP and Jaeger exporter belong to core repo. Rest of the exporters should be contributed to contrib repo.
Accordingly, ETW exporter should be moved to opentelemetry-cpp-contrib repo.

@lalitb lalitb added good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers do-not-stale labels Jun 2, 2022
@marcalff
Copy link
Member

marcalff commented Nov 2, 2022

This fix is blocking resolution of #1448

@marcalff marcalff added the issue:blocking This issue is preventing other fixes label Nov 2, 2022
@lalitb
Copy link
Member Author

lalitb commented Feb 22, 2023

As part of the movement, also need to remove TraceLoggingDynamics.h file which comes with different MIT license and Microsft Copyright, and use the OSS repo - https://github.com/microsoft/tracelogging - as submodule which brings this file.

@ThomsonTan
Copy link
Contributor

With the above spec link, I don't see it mentioned explicitly that exporters other than OTLP, Zipkin.

One more thing to consider it moving ETW to contrib will need to update vcpkg to install opentelemtry-cpp[etw] in order to not to break the current installation flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-stale good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers issue:blocking This issue is preventing other fixes
Projects
None yet
Development

No branches or pull requests

3 participants