Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libraries delivered: Reconcile Bazel and CMake build #1428

Open
marcalff opened this issue Jun 3, 2022 · 3 comments
Open

Libraries delivered: Reconcile Bazel and CMake build #1428

marcalff opened this issue Jun 3, 2022 · 3 comments
Labels
bug Something isn't working do-not-stale help wanted Good for taking. Extra help will be provided by maintainers

Comments

@marcalff
Copy link
Member

marcalff commented Jun 3, 2022

This is a remaining item identified during review of PR #1420

(1)

Document:

  • the name of each library delivered
  • the expected dependency graph (DAG)

This documentation is meant to be used by:

  • users of opentelemetry-cpp,
  • maintainers of opentelemetry-cpp.

A good place could be docs/library-distribution.md

(2)

Fix the Bazel build to comply with (1)

(3)

Fix the CMake build to comply with (1)

Libraries build with Bazel or CMake should be the same.

@marcalff marcalff added the bug Something isn't working label Jun 3, 2022
@lalitb lalitb added the help wanted Good for taking. Extra help will be provided by maintainers label Jun 3, 2022
@yxue
Copy link
Contributor

yxue commented Jul 10, 2022

Do we consider use the tools like https://github.com/google/bazel-to-cmake? The CMakeLists.txt can be generated from the BUILD and WORKSPACE as mentioned.

@owent
Copy link
Member

owent commented Jul 11, 2022

I think it's difficult to use bazel-to-cmake like tools. CMake support environment detection better and has a better compatibility then bazel.(e.g. We support gcc 4.8 and use a old version of gRPC and abseil-cpp with cmake, but we don't suport legacy compilers with bazel now).
Maybe we can consider If there is a tool than can convert cmake script to bazel script, or just write a script to check if is there any target name different between bazel and cmake?

@github-actions
Copy link

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Sep 10, 2022
@lalitb lalitb removed the Stale label Sep 17, 2022
@lalitb lalitb reopened this Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working do-not-stale help wanted Good for taking. Extra help will be provided by maintainers
Projects
None yet
Development

No branches or pull requests

4 participants