Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics SDK] Add Metrics ExemplarFilter and ExemplarReservoir #1498

Closed
esigo opened this issue Jul 17, 2022 · 0 comments · Fixed by #1584
Closed

[Metrics SDK] Add Metrics ExemplarFilter and ExemplarReservoir #1498

esigo opened this issue Jul 17, 2022 · 0 comments · Fixed by #1584
Assignees
@esigo
Labels
bug Something isn't working priority:p2 Issues that are not blocking
Milestone
Metrics v1.0.0 (GA)

Comments

@esigo
Copy link
Member

esigo commented Jul 17, 2022

Specs: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#exemplar

ExemplarFilter determines if a measurement should be sampled
Properties - value of measurement, attributes of measurement, context of measurement, timestamp

ExemplarReservoir provides a method to offer measurements to the reservoir and to collect accumulated exemplars
@esigo esigo added the bug Something isn't working label Jul 17, 2022
@esigo esigo self-assigned this Jul 17, 2022
@lalitb lalitb added the priority:p2 Issues that are not blocking label Aug 24, 2022
@esigo esigo mentioned this issue Aug 28, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esigo esigo

Labels
bug Something isn't working priority:p2 Issues that are not blocking
Projects
None yet
Milestone
Metrics v1.0.0 (GA)
Development

Successfully merging a pull request may close this issue.

[Metrics SDK] Add Metrics ExemplarFilter and ExemplarReservoir esigo/opentelemetry-cpp
2 participants
@lalitb @esigo