Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTLP Exporter] OTLP gRPC exporter cmake build shouldn't depend on nlohmann-json #1502

Closed
lalitb opened this issue Jul 18, 2022 · 0 comments · Fixed by #1505
Closed

[OTLP Exporter] OTLP gRPC exporter cmake build shouldn't depend on nlohmann-json #1502

lalitb opened this issue Jul 18, 2022 · 0 comments · Fixed by #1505
Labels
area:exporter:otlp OpenTelemetry Protocol (OTLP) Exporter area:exporter bug Something isn't working

Comments

@lalitb
Copy link
Member

lalitb commented Jul 18, 2022

Describe your environment - ubuntu, libcurl not installed, gRPC installed.

Steps to reproduce
$ cmake -DWITH_OTLP=ON ..

What is the expected behavior?
As OTLP GRPC exporter doesn't use JSON serialization, its build shouldn't try installing nlohmann-json if package is not already installed.

What did you expect to see?
Build should succeed without nlohmann-json.

What is the actual behavior?
Build tries to install nlohmann-json from submodules, or from outside if missing.

Additional context
None

@lalitb lalitb added bug Something isn't working area:exporter area:exporter:otlp OpenTelemetry Protocol (OTLP) Exporter labels Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:exporter:otlp OpenTelemetry Protocol (OTLP) Exporter area:exporter bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant