Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics SDK] - Validate Instrument meta data (name, unit, description) #1712

Closed
lalitb opened this issue Oct 26, 2022 · 0 comments · Fixed by #1713
Closed

[Metrics SDK] - Validate Instrument meta data (name, unit, description) #1712

lalitb opened this issue Oct 26, 2022 · 0 comments · Fixed by #1713
Assignees
Labels
bug Something isn't working

Comments

@lalitb
Copy link
Member

lalitb commented Oct 26, 2022

Metrics Specs specifies the Instrument naming rules - https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#instrument-naming-rule

Valid Instruments should be created only if the name, unit and description are compliant with these naming rules.

Also, adding it after GA would be a breaking change specifically for the non-compliant instruments created before enabling this validation. Once validation is enabled, it won't be possible to send the metrics for these non-compliant instruments.
So scoping this for GA.

@lalitb lalitb added the bug Something isn't working label Oct 26, 2022
@lalitb lalitb self-assigned this Oct 26, 2022
@lalitb lalitb added this to the Metrics v1.0.0 (GA) milestone Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant