Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics API/SDK] - Support multiple Instrument callbacks #1753

Open
lalitb opened this issue Nov 9, 2022 · 3 comments
Open

[Metrics API/SDK] - Support multiple Instrument callbacks #1753

lalitb opened this issue Nov 9, 2022 · 3 comments
Assignees
Labels
breaking change API or ABI breaking change do-not-stale

Comments

@lalitb
Copy link
Member

lalitb commented Nov 9, 2022

As per the specs -

"The Metrics API MAY support an interface allowing the use of multiple instruments from a single registered Callback."

As of now, implementation supports registering multiple callbacks to single instruments. While specs also optionally allows registering single callback with multiple instruments (so multiple measurements can be returned from single callback functions).

@lalitb lalitb added this to the Metrics post GA release milestone Nov 9, 2022
@lalitb lalitb changed the title [Metrics API/SDK] - Multiple Instrument callbacks [Metrics API/SDK] - Support multiple Instrument callbacks Nov 9, 2022
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Jan 9, 2023
@lalitb lalitb added do-not-stale and removed Stale labels Jan 9, 2023
@marcalff marcalff added the breaking change API or ABI breaking change label Mar 23, 2023
@marcalff
Copy link
Member

Adding the breaking change label: this will require a new API, hence changing the API ABI for metrics.

@marcalff
Copy link
Member

Supporting multiple instruments in a single callback is valuable when an expensive computation is needed to get the data.

A typical example is reporting multiple instruments at once when reading a /proc file.

@marcalff marcalff removed this from the Metrics post GA release - 2 milestone Jan 29, 2024
@marcalff marcalff self-assigned this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change API or ABI breaking change do-not-stale
Projects
None yet
Development

No branches or pull requests

2 participants