Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error with clang-19 #3124

Closed
veblush opened this issue Nov 5, 2024 · 1 comment · Fixed by #3133
Closed

Build error with clang-19 #3124

veblush opened this issue Nov 5, 2024 · 1 comment · Fixed by #3133
Labels
bug Something isn't working

Comments

@veblush
Copy link

veblush commented Nov 5, 2024

Describe your environment

Build HEAD with clang-19

Steps to reproduce

Using the environment having clang-19 such as the docker image, silkeh/clang:19, build opentelemetry-cpp with cmake.

What is the expected behavior?

Built succesfully.

What is the actual behavior?

Clang 19 throws compilation errors as follows

opentelemetry-cpp/api/include/opentelemetry/logs/logger_type_traits.h:164:69: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
  164 |     return LogRecordSetterTrait::template Set(
      |                                                                     ^

opentelemetry-cpp/api/include/opentelemetry/logs/logger.h:76:89: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
   76 |         detail::LogRecordSetterTrait::type>::template Set(
      |                                                                                         ^

opentelemetry-cpp/api/include/opentelemetry/logs/event_logger.h:73:89: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
   73 |         detail::LogRecordSetterTrait::type>::template Set(
      |                                                                                         ^

Additional context

Clang-18 is able to build it so this is a new issue from clang-19. llvm/llvm-project#94194 is the reference point about this issue. Note that missing-template-arg-list-after-template-kw is treated as an error by default.

@veblush veblush added the bug Something isn't working label Nov 5, 2024
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 5, 2024
@veblush
Copy link
Author

veblush commented Nov 5, 2024

@yashykt FYI

@marcalff marcalff removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants