Rename SpanContext to SpanReference

[ThomsonTan]

Update needed to track these changes: open-telemetry/opentelemetry-specification#1075

[TuckTuckFloof]

Is this issue still open?

[ThomsonTan]

@TuckTuckFloof yes, are you interested to help this?

[TuckTuckFloof]

Yea, I've been looking to do some open source stuff, complete first timer, now what do I have to do?

[ThomsonTan]

Take a look at the spec link open-telemetry/opentelemetry-specification#1075, make sure all the occurrences are correctly renamed in this repo, and follow our contribution guideline here.

[TuckTuckFloof]

I'm in, so look for more instances like the one in the spec link and make a pr then?

[ThomsonTan]

That's right. Just a reminder, please also take a look at the contribution guideline above before uploading PR. Thanks and happy contributing.

[TuckTuckFloof]

Thank you, and will do. I've already forked it and found 1 instance lol.

[TuckTuckFloof]

Oh, I found span_context, would you like me to change those to span_reference for consistency?

[ThomsonTan]

That's a good find. I think it is great to keep it consistent with the struct name. @open-telemetry/cpp-approvers please share thoughts.

[TuckTuckFloof]

Alright, I got it done, I'm gonna hang around before the PR though, just in case you guys want me to change span_context to span_reference, as stated before

[TuckTuckFloof]

@ThomsonTan Do you think I should just make a PR as is or should I wait for other responses?

[ThomsonTan]

I think it is fine to create the PR.

[TuckTuckFloof]

you got it

[TuckTuckFloof]

Ok, so I couldn't get the tools/format.sh file to work, couldnt find buildifier and the link to get it just doesn't exist apparently

[lalitb]

Make sure you install formatting tool by running this script.

[TuckTuckFloof]

Oh, thank you, I hope this'll get it to work

[TuckTuckFloof]

Alright, commited.

Edit: I don't think it PR'd, so we can solve this in the morning, because I couldn't get it to pr for some reason.

[TuckTuckFloof]

Alright, I'm back, it's telling me that considering that they are different commit histories, I can't make a PR

[ThomsonTan]

Could you please share the detailed error message of creating the PR? Could you please try rebase your change to the latest and create PR again?

[TuckTuckFloof]

I'll try the rebase because it literally doesn't say anything else other than that they're different commit histories. Which is weird because it shows me the changes I made.

[lalitb]

Please hold on this change, as there is ongoing discussion to revert back this renaming:

open-telemetry/opentelemetry-specification#1126

[lalitb]

@ThomsonTan closing this issue -as the changes in specs are reverted back - open-telemetry/opentelemetry-specification#1127.