Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding span collection limits #365

Closed
lalitb opened this issue Oct 16, 2020 · 7 comments
Closed

Adding span collection limits #365

lalitb opened this issue Oct 16, 2020 · 7 comments
Assignees
Labels
area:sdk priority:p2 Issues that are not blocking Stale

Comments

@lalitb
Copy link
Member

lalitb commented Oct 16, 2020

As per the recent spec change :

Max attributes per span : 1000
Max links per span : 1000
Max events per span : 1000

The upper bound needs to be validated.

@lalitb lalitb added the bug Something isn't working label Oct 16, 2020
@ThomsonTan ThomsonTan added the good first issue Good for newcomers label Oct 21, 2020
@pyohannes
Copy link
Contributor

Those limits are not mandatory by the spec (they're a MAY), so I will remove the bug label.

@pyohannes pyohannes added area:sdk and removed bug Something isn't working good first issue Good for newcomers labels Oct 22, 2020
@lalitb lalitb added the priority:p2 Issues that are not blocking label Dec 16, 2020
@lalitb lalitb self-assigned this Apr 21, 2021
@lalitb
Copy link
Member Author

lalitb commented Apr 21, 2021

@anshulkumar19 - I have assigned it to myself, while you are working on it ( to ensure there is no parallel work on it ).

@anshulkumar19
Copy link
Contributor

Thanks @lalitb

@anshulkumar19
Copy link
Contributor

@lalitb Currently this is WIP (span limit struct is added but constraint is used only in span_data ), intended to get it reviewed from the perspective of complexity introduced in current structure as this is an optional feature suggested by the spec.

@lalitb
Copy link
Member Author

lalitb commented Jun 2, 2021

Thanks @anshulkumar19 - Will review it in regards to the complexity introduced.

@github-actions
Copy link

This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.

@github-actions github-actions bot added the Stale label Nov 24, 2021
@lalitb
Copy link
Member Author

lalitb commented Nov 24, 2021

closing as this is optional requirement, and there is no plan to implement these limits.

@lalitb lalitb closed this as completed Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk priority:p2 Issues that are not blocking Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants