Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define default timeout for all processor and exporter interfaces #418

Closed
kxyr opened this issue Dec 3, 2020 · 2 comments
Closed

Define default timeout for all processor and exporter interfaces #418

kxyr opened this issue Dec 3, 2020 · 2 comments
Labels
priority:p2 Issues that are not blocking

Comments

@kxyr
Copy link
Contributor

kxyr commented Dec 3, 2020 •
edited
Loading

An idiomatic timeout that is finite should be defined consistently for traces, metrics, and logs, for the ForceFlush() and Shutdown() methods of the Processor, and the Export() and Shutdown() methods of the Exporters. This timeout should ensure these methods never block indefinitely, as per the spec.
@kxyr kxyr mentioned this issue Dec 3, 2020
Merged
@lalitb lalitb added the priority:p2 Issues that are not blocking label Dec 16, 2020
@lalitb
Copy link
Member

lalitb commented Jan 13, 2021

#419 fixes it. @ThomsonTan to confirm ?

@ThomsonTan
Copy link
Contributor

#419 fixes it. @ThomsonTan to confirm ?

Yes, set timeout to std::chrono::microseconds::max() resolves this issue.

@lalitb lalitb closed this as completed Jan 13, 2021
@loong-hy loong-hy mentioned this issue Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:p2 Issues that are not blocking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ThomsonTan @lalitb @kxyr