Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finding a workaround for silently dropping spans and logs #441

Closed
kxyr opened this issue Dec 12, 2020 · 4 comments
Closed

Finding a workaround for silently dropping spans and logs #441

kxyr opened this issue Dec 12, 2020 · 4 comments
Labels
bug Something isn't working do-not-stale help wanted Good for taking. Extra help will be provided by maintainers priority:p1 Issues that are blocking Stale

Comments

@kxyr
Copy link
Contributor

kxyr commented Dec 12, 2020

A current issue in the Logger and Tracer implementation is in some places, spans and logs may be silently dropping.

This could happen for Logs when a Logger tries to get a recordable from processor->MakeRecordable(). Since the processor could have thrown an std::bad_alloc exception but handled it and simply returned a nullptr to the Logger. The Logger would have a nullptr value for the Recordable, but would not know the reason that the nullptr was returned.

This could happen in all places where errors/exceptions are hidden or handled by the callee itself, without being bubbled up to the caller.

This is an issue that is flagged and would need to be resolved for the future

Related issue: #408

@kxyr kxyr added the bug Something isn't working label Dec 12, 2020
@kxyr kxyr changed the title Caller unaware of exceptions and silently dropping spans and logs Finding a workaround for silently dropping spans and logs Dec 12, 2020
@lalitb lalitb added priority:p1 Issues that are blocking help wanted Good for taking. Extra help will be provided by maintainers labels Dec 16, 2020
@github-actions
Copy link

This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.

@github-actions github-actions bot added the Stale label Nov 22, 2021
@lalitb lalitb removed the Stale label Nov 22, 2021
@github-actions
Copy link

This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.

@github-actions
Copy link

This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.

@github-actions github-actions bot added the Stale label Mar 24, 2022
@github-actions
Copy link

Closed as inactive. Feel free to reopen if this is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working do-not-stale help wanted Good for taking. Extra help will be provided by maintainers priority:p1 Issues that are blocking Stale
Projects
None yet
Development

No branches or pull requests

2 participants