Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple tracers in TracerProvider #694

Closed
ThomsonTan opened this issue Apr 23, 2021 · 1 comment
Closed

Support multiple tracers in TracerProvider #694

ThomsonTan opened this issue Apr 23, 2021 · 1 comment
Assignees
@ThomsonTan
Labels
bug Something isn't working
Milestone
1.0.0-rc.1

Comments

@ThomsonTan
Copy link
Contributor

TracerProvider could only host 1 Tracer object because Tracer is class member of TracerProvider class. We need support multiple traces in TracerProvider after we add InstrumentationLibrary which acts as identifier of the Tracer.

opentelemetry-cpp/sdk/include/opentelemetry/sdk/trace/tracer_provider.h

Line 76 in a978920

std::shared_ptr<opentelemetry::trace::Tracer> tracer_;

@ThomsonTan ThomsonTan added the bug Something isn't working label Apr 23, 2021
@ThomsonTan ThomsonTan mentioned this issue Apr 23, 2021
Merged
3 tasks
@ThomsonTan ThomsonTan self-assigned this Apr 24, 2021
@lalitb lalitb added this to the 1.0.0-rc.1 milestone Apr 26, 2021
@ThomsonTan
Copy link
Contributor Author

Fixed by #693.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomsonTan ThomsonTan

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0-rc.1
Development

No branches or pull requests
2 participants
@ThomsonTan @lalitb