Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming SDK Recordable class name to reflect the underlying transport #735

Closed
ThomsonTan opened this issue May 10, 2021 · 0 comments · Fixed by #919
Closed

Renaming SDK Recordable class name to reflect the underlying transport #735

ThomsonTan opened this issue May 10, 2021 · 0 comments · Fixed by #919
Assignees
@ThomsonTan
Labels
bug Something isn't working

Comments

@ThomsonTan
Copy link
Contributor

Based on below comment, the class Recordable in SDK has the same name of its interface class in API which makes it unclear for readers/reviewers. What's more, using this general name make it hard to support multiple transport types in one exporter.

https://github.com/open-telemetry/opentelemetry-cpp/pull/534/files#r615903167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomsonTan ThomsonTan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename Recordable to JaegerRecordable in Jaeger exporter ThomsonTan/opentelemetry-cpp
1 participant
@ThomsonTan