Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use local GSL #914

Closed
owent opened this issue Jul 21, 2021 · 2 comments
Closed

Allow to use local GSL #914

owent opened this issue Jul 21, 2021 · 2 comments

Comments

@owent
Copy link
Member

owent commented Jul 21, 2021

Is your feature request related to a problem?
I found ms-gsl is a excellent tool to write modern C++ codes, and I want to use it in my project.At the same time I think it's better to let opentelemetry use the same ms-gsl.

Describe the solution you'd like
find_package(Microsoft.GSL QUIET) before set(GSL_DIR third_party/ms-gsl) and include_directories(${GSL_DIR}/include)

Describe alternatives you've considered
I find another library - gsl-lite and it seems have better compatibility for old compilers. Maybe we can use it for old compilers?

Additional context
None

@lalitb
Copy link
Member

lalitb commented Aug 4, 2021

@owent - Can we close this issue, if #915 fixes it.

@owent
Copy link
Member Author

owent commented Aug 5, 2021

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants