Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message must be ignored when status code is ok on Span->SetStatus #957

Closed
jsuereth opened this issue Aug 19, 2021 · 0 comments · Fixed by #962
Closed

Error message must be ignored when status code is ok on Span->SetStatus #957

jsuereth opened this issue Aug 19, 2021 · 0 comments · Fixed by #962
Labels
bug Something isn't working spec-compliance Not compliant to OpenTelemetry specs

Comments

@jsuereth
Copy link
Contributor

Right now this behavior is delegated to Recordable (e.g. see https://github.com/open-telemetry/opentelemetry-cpp/blob/main/exporters/otlp/src/otlp_recordable.cc#L293)

The spec states:

An API to set the Status. This SHOULD be called SetStatus. This API takes the StatusCode, and an optional Description, either as individual parameters or as an immutable object encapsulating them, whichever is most appropriate for the language. Description MUST be IGNORED for StatusCode Ok & Unset values.
@jsuereth jsuereth added bug Something isn't working spec-compliance Not compliant to OpenTelemetry specs labels Aug 19, 2021
@jsuereth jsuereth mentioned this issue Aug 19, 2021
Closed
13 tasks
@lalitb lalitb mentioned this issue Aug 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working spec-compliance Not compliant to OpenTelemetry specs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Otlp exporter: Ignore status description if status code is not Error. lalitb/opentelemetry-cpp
1 participant
@jsuereth