Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Add public API to retrieve target table name from TableNameMappings for a given category #2308

Open
evgenyfedorov2 opened this issue Nov 8, 2024 · 3 comments
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva enhancement New feature or request

Comments

@evgenyfedorov2
Copy link
Contributor

Component

OpenTelemetry.Exporter.Geneva

Is your feature request related to a problem?

In my library I work with GenevaExporterOptions.TableNameMappings property, but the logic to calculate the resulting table name where each log category will be exported to is complicated and internal. Please provide public API (in the form of an extension method or something like that) so that it could return a table name for a given category.

What is the expected behavior?

Please provide public API (in the form of an extension method or something like that) so that it could return a table name for a given category.

public string ResolveTableMappingForCategoryName(this GenevaExporterOptions options, string categoryName) {...}

Which alternative solutions or features have you considered?

As a workaround, I have to duplicate/copypaste the existing internal Geneva exporter code for resolving table name for a category name

Additional context

No response

@evgenyfedorov2 evgenyfedorov2 added the enhancement New feature or request label Nov 8, 2024
@github-actions github-actions bot added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Tagging component owner(s).

@cijothomas @CodeBlanch @rajkumar-rangaraj @reyang @utpilla

@xiang17
Copy link
Contributor

xiang17 commented Nov 13, 2024

Hi, can you elaborate what's your use case? Why would you need to get the table name via an API?

@evgenyfedorov2
Copy link
Contributor Author

Hi, can you elaborate what's your use case? Why would you need to get the table name via an API?

Hi, I tried to explain it in the Workaround section. In our internal Microsoft library we have some code to check which Geneva table every log record is going to be exported to, and then we have some internal logic to proceed depending on the table name.
So, we don't want to copy/paste the TableNameMappings resolving logic into our codebase and then support it and try to keep it in sync with the official logic located in this repo, it is problematic. Instead, it would be great to be able to call a method (like ResolveTableMappingForCategoryName) which would return calculated target table name for provided category.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants