Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage: add integration test using ReadyToRun/NGEN #1284

Open
pjanotti opened this issue Sep 28, 2022 · 2 comments
Open

Test coverage: add integration test using ReadyToRun/NGEN #1284

pjanotti opened this issue Sep 28, 2022 · 2 comments
Milestone

Comments

@pjanotti
Copy link
Contributor

pjanotti commented Sep 28, 2022

[EDIT: update to clarify that this is about ReadyToRun not AOT]

The code requesting ReJIT of methods targeted for bytecode instrumentation is missing coverage in the following cases:

  1. Instrumenting a method from a module that was NGENed/ReadyToRun;
  2. Instrumenting a method that was inlined;
  3. Instrumenting a method that was inlined and is used by a module that was NGENed;
@Kielek
Copy link
Contributor

Kielek commented Sep 28, 2022

SIG meeting notes:
Create test similar to StrongNamedAssembly.
Our testapp/testlibrary should include method marked as forced inlining. Our bytecode instrumentation should include instrumentation for it (remember about json definition). Then we should cover everything by tests.

@Kielek
Copy link
Contributor

Kielek commented Feb 15, 2023

@Kielek Kielek modified the milestones: 1.0.0-rc.1, 1.0.0-rc.2 Apr 27, 2023
@pjanotti pjanotti changed the title Test coverage: add integration test using AOT/NGEN Test coverage: add integration test using ReadyToRun/NGEN May 19, 2023
@Kielek Kielek modified the milestones: 1.0.0-rc.2, post-1.0.0 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants