Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf improvement using zero-alloc foreach #1080

Closed
reyang opened this issue Aug 14, 2020 · 3 comments
Closed

Perf improvement using zero-alloc foreach #1080

reyang opened this issue Aug 14, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@reyang
Copy link
Member

reyang commented Aug 14, 2020

#1078 (comment)

Potential places that we want to improve:

  1. Processor chain (CompositeActivityProcessor).
  2. Exporter interface (a batch of spans).
  3. Resource attributes.
@reyang reyang added the enhancement New feature or request label Aug 14, 2020
This was referenced Aug 14, 2020
@reyang
Copy link
Member Author

reyang commented Aug 18, 2020

@CodeBlanch has an idea of using union approach to address the IEnumerator improvement among Processor/CircularBuffer/Exporter.

@martinjt
Copy link
Member

There's been a fix related to this, if there's more work I'd suggest a more targeted suggestion.

@martinjt
Copy link
Member

Most of the work has completed, if there's more work then you can reopen with the specific suggestions and why, or create a new targeted ticket for them.

I think there's been a tonne of work around allocations in the project, so it's probably something that has already been done. So I'm going to mark this as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants